bugfix/signal_13_when_closing_read_pipe#29
Open
Amir-Zucker wants to merge 1 commit intochesskit-app:masterfrom
Open
bugfix/signal_13_when_closing_read_pipe#29Amir-Zucker wants to merge 1 commit intochesskit-app:masterfrom
Amir-Zucker wants to merge 1 commit intochesskit-app:masterfrom
Conversation
…om forked repo - ignore SIGPIP if we encounter one during initialization - Ensure we remove the read observer before we try to close the pipes - Added checks to ensure write pipe is still valid before sending new commands.
Contributor
Author
|
This branch was created from the latest commit in the master branch of this repo, I then cherry picked the relevant commit from the bugfix branch and opened a PR back to this repo. Not sure why codecov complains about reduction in code coverage on files that are unrelated to the commit nor were they changed at any point. This PR might cause conflicts with PR #27 since we both made changes to line 29 of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes when we stop the engine and close the read pipe we receive a signal 13, which leads to the app being terminated. This happens because we are still receiving new data after the read pipe was already closed.
Admittedly this is more prevalent with Arasan Chess Engine which is not a part of this repo, but it might still happen with Stockfish and LC0.
Changes done and their purpose.
closeFilemethod withcloseAndReturnError:.No new tests were added, as the changes that were made are already being covered by existing ones.
Cheers!