Revamped the check digit calculation#10
Open
gtmsingh wants to merge 3 commits intochilts:masterfrom
gtmsingh:master
Open
Revamped the check digit calculation#10gtmsingh wants to merge 3 commits intochilts:masterfrom gtmsingh:master
gtmsingh wants to merge 3 commits intochilts:masterfrom
gtmsingh:master
Conversation
inspired by: #8 * Added `V` as the replacement for `Y` character (thus appropriately reducing number of symbols) * Made the modulo operation (in `checkDigitAlg1`) to auto adjust to the size of the symbols array and thus including all the symbols in a pseudo random fashion. * Added a concise guideline regarding why not to use 32 (or any 2^x number) as modulo with the link to the issue discussing about the same.
Since `Y` is being replaced by `V` previous parts containing `Y` would not have same check digit
Mistakenly updated the check digit for a `Y`character containing part that should fail according to the test case scenario
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inspired by: #8
Vas the replacement forYcharacter (thus appropriately reducing number of symbols)checkDigitAlg1) to auto adjust to the size of the symbols array and thus including all the symbols in a pseudo random fashion.