Spauldingv code review1 by spauldvl · Pull Request #8 · chintavs/Workout-App

spauldvl · 2023-03-05T02:03:00Z

This is a workout logging app designed to be able to track your own workouts and find workouts from the JSON data. The user can also make groups for workouts as well.
Yes, submitted on time.
Yes, the program is well documented. There are comments explaining pretty much what each function and class does.
The unit tests did not compile for me. I'm not sure if it was because of my computer or I was looking at the wrong branch or something.

What I learned:
Using scaffold for navigation
I can have different UI features in different files and implement them into MainActivity
Different UI features like Box and different modifiers for Text to make UI better

Adding Android Project

Added basic layout for Groups page.

Groups page

Implement data from json later to pass tests

-Updated Theme folder

…ain_Page2 � Conflicts: � app/src/main/java/com/example/workoutapp/MainActivity.kt

spauldvl · 2023-03-05T02:03:50Z

    androidTestImplementation "androidx.compose.ui:ui-test-junit4:$compose_ui_version"
    debugImplementation "androidx.compose.ui:ui-tooling:$compose_ui_version"
    debugImplementation "androidx.compose.ui:ui-test-manifest:$compose_ui_version"
+    implementation 'com.squareup.retrofit2:retrofit:2.9.0'


had to change version for retrofit2 to work

spauldvl · 2023-03-05T02:04:30Z

+    }
+
+}
+@Preview(name="Light Mode", showBackground=true)


added preview so emulator would not need to be reran

spauldvl · 2023-03-05T02:05:28Z

+    }
 }

-@Preview(showBackground = true)


this line was redlining and didn't work to show preview

spauldvl · 2023-03-05T02:08:04Z

+
+
+@Preview(name="Light Mode", showBackground=true)
+@Preview(uiMode= Configuration.UI_MODE_NIGHT_YES, showBackground = true, name="Dark Mode")


refactored to make preview work

spauldvl · 2023-03-05T02:08:53Z

@@ -0,0 +1,21 @@
+package com.example.workoutapp


added missing RetrofitClientInstance file. Implementing this and DAO and DTO packaged should help make unit tests run.

spauldvl · 2023-03-05T02:09:11Z

+
+object RetrofitClientInstance {
+    private var retrofit: Retrofit? = null
+    private val BASE_URL = ""


add your own base URL from your JSON link (boilerplate code)

spauldvl · 2023-03-05T02:09:50Z

+
+    }
+}
+@Preview(name="Light Mode", showBackground=true)


added another preview

spauldvl · 2023-03-05T02:10:37Z

@@ -0,0 +1,6 @@
+package com.example.workoutapp.service


need to implement WorkoutService with fetchWorkouts function to parse JSON data

This appears to be an incomplete feature, as there's not a BASE_URL. Recommendation: if not used, remove it, or keep it in a separate development branch until it is complete.

Keep the codebase as small as possible to do the job you want to do. Unused code is clutter, and bad documentation, which increases technical debt.

Only complete features, which meet the team's Definition of Done, should be merged to Main/Master.

spauldvl · 2023-03-05T02:11:44Z

+
+    @Test
+    fun `Given a dto when name is Barbell Curl, and level is beginner`() {
+        var workout = Workout("Barbell Curl", "pull", "beginner", "isolation", "barbell", "biceps", "forearms",


need to implement Workout class

spauldvl · 2023-03-05T02:12:25Z

@@ -0,0 +1,167 @@
+package com.example.workoutapp


these unit tests failed for me because of lack to implement necessary classes for it

spauldvl · 2023-03-05T03:29:57Z

+import retrofit2.http.GET
+
+interface IWorkoutDAO {
+    @GET("")


put your own json link here

This appears to be an incomplete feature, as there's not a BASE_URL. Recommendation: if not used, remove it, or keep it in a separate development branch until it is complete.

Keep the codebase as small as possible to do the job you want to do. Unused code is clutter, and bad documentation, which increases technical debt.

Only complete features, which meet the team's Definition of Done, should be merged to Main/Master.

spauldvl · 2023-03-05T03:30:40Z

@@ -0,0 +1,5 @@
+package com.example.workoutapp.dto
+
+class Workout {


I couldn't find your json link anywhere to come up with the workout class myself

discospiff · 2023-03-05T19:25:10Z

Some good suggestions here, though I wouldn't recommend merging this branch at this time.

For the project group, all work should be merged to main before code review. Reviewing separate branches, without a holistic view of the application, is of limited benefit, in this case.
This branch introduces new, and sometimes incomplete, functionality. New functionality is better in a separate branch until fully developed, as features should not be merged to main/master until the meet the team's Definition of Done. Code review branches should minimize technical debt, and thus, be merge-able to master immediately. So, if the team desires these features, I'd keep the branch open, and iterate over the feature until it is complete.

daltonco and others added 13 commits February 5, 2023 15:26

Merge pull request #3 from chintavs/Main-Files

9cbc8cd

Adding Android Project

Renamed MainActivity.kt to GroupsActivity.kt

ff46830

Added basic layout for Groups page.

Merge pull request #5 from chintavs/Groups_Page

c7931ad

Groups page

Added Basic test

4a342d3

Implement data from json later to pass tests

Update Home Page

8b9133f

-Added Profile Page

9b929e0

-Updated Theme folder

-Navbar added

f073498

Finished UnitTest

b77995f

Merge branch 'test' of https://github.com/chintavs/Workout-App into M…

b614395

…ain_Page2 � Conflicts: � app/src/main/java/com/example/workoutapp/MainActivity.kt

-Comments added

d861913

Code review 1 by vyviene spaulding

7a9b06e

Code review 1 by vyviene spaulding

d72c9f0

Code review 1 by vyviene spaulding

ceeefa1

spauldvl commented Mar 5, 2023

View reviewed changes

Code review 1 by vyviene spaulding

8282369

spauldvl commented Mar 5, 2023

View reviewed changes



		@Preview(name="Light Mode", showBackground=true)
		@Preview(uiMode= Configuration.UI_MODE_NIGHT_YES, showBackground = true, name="Dark Mode")

		@@ -0,0 +1,5 @@
		package com.example.workoutapp.dto

		class Workout {

Conversation

spauldvl commented Mar 5, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spauldvl Mar 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

discospiff commented Mar 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

spauldvl Mar 5, 2023 •

edited

Loading