-
Notifications
You must be signed in to change notification settings - Fork 0
ci: add compliance gate job for org ruleset #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Copilot Autofix
AI 2 days ago
To fix the problem, explicitly declare a
permissions:block that applies least-privilege settings to the workflow. Since neither job in this snippet needs to write to the repository and thecompliancejob appears to not use the token at all, we can setpermissions: contents: readat the workflow root as a minimal, safe default. This documents the intended permissions and prevents escalation if repo/org defaults are broader. If the reusable workflowreusable-compliance-check.ymlneeds more granular permissions, they should be declared there; here we only constrain this workflow.The best single change with no functional impact is to add a root-level
permissions:block after thename:(or afteron:) in.github/workflows/compliance-check.yml, settingcontents: read. This applies to all jobs that do not override permissions, including bothcheckandcompliance. No imports or additional methods are needed; this is purely a YAML configuration change inside the workflow file.Concretely, in
.github/workflows/compliance-check.yml, insert:after line 2 (or any valid root position before
jobs:). No other changes are required.