Skip to content

fix: use direct Cloudflare secrets for deploy workflows#42

Merged
chitcommit merged 1 commit intomainfrom
fix/direct-deploy-secrets
Mar 17, 2026
Merged

fix: use direct Cloudflare secrets for deploy workflows#42
chitcommit merged 1 commit intomainfrom
fix/direct-deploy-secrets

Conversation

@chitcommit
Copy link
Contributor

Summary

  • Switches from OIDC-based credential fetch to direct GitHub secrets for both deploy-worker and deploy-pages workflows
  • Removes id-token: write permission (no longer needed)
  • Simplifies deploy-pages by removing the get-credentials job entirely

Context

Cloudflare WAF blocks GitHub Actions IPs from reaching connect.chitty.cc, making the OIDC zero-secret approach non-functional. Direct secrets match the pattern used by chittyconnect's own deploy workflow.

Required setup

After merging, set these repo secrets:

  • CLOUDFLARE_API_TOKEN — Cloudflare API token with Workers deploy permissions
  • CLOUDFLARE_ACCOUNT_ID — Cloudflare account ID

Depends on

🤖 Generated with Claude Code

Cloudflare WAF blocks GitHub Actions IPs from reaching ChittyConnect,
making OIDC-based credential fetch impossible. Switch to direct
CLOUDFLARE_API_TOKEN and CLOUDFLARE_ACCOUNT_ID secrets.

Also simplifies deploy-pages.yml by removing the get-credentials job
and using secrets directly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

Warning

Rate limit exceeded

@chitcommit has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 56 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f3492928-173b-4694-a5d6-3ef3068ae6ec

📥 Commits

Reviewing files that changed from the base of the PR and between 8ac11ff and d0d2907.

📒 Files selected for processing (2)
  • .github/workflows/deploy-pages.yml
  • .github/workflows/deploy-worker.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/direct-deploy-secrets
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

  1. @coderabbitai review
  2. @copilot review
  3. @codex review
  4. @claude review
    Adversarial review request: evaluate security, policy bypass paths, regression risk, and merge-gating bypass attempts.


- name: Deploy to Cloudflare Pages
uses: cloudflare/wrangler-action@da0e0dfe58b7a431659754fdf3f186c529afbe65 # v3
uses: cloudflare/wrangler-action@v3

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'Deploy Pages' step
Uses Step
uses 'cloudflare/wrangler-action' with ref 'v3', not a pinned commit hash
@chitcommit chitcommit merged commit 426a0b7 into main Mar 17, 2026
15 of 17 checks passed
@chitcommit chitcommit deleted the fix/direct-deploy-secrets branch March 17, 2026 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant