Add governance instructions for production code#19
Conversation
Added governance and coding guidelines for production code in a multi-repo environment, covering priorities, security, quality, and review policies.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@coderabbitai review |
📝 WalkthroughWalkthroughA new governance policy document is introduced that outlines development priorities, security requirements, coding standards, PR guidelines, and review procedures. The document prescribes observable behavior for development workflows without introducing executable logic. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds a repository instruction file intended to guide production-code changes in a governance-heavy multi-repo environment (security, quality, review policy, and response style).
Changes:
- Added governance/coding guidelines covering priorities, security requirements, quality/compatibility, PR policy, and governance constraints.
- Added response-style guidance for reviewers/assistants.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/instructions/*.instructions.md:
- Around line 33-40: Update the PR policy block to explicitly require code-owner
approval for changes to workflow and setup files by adding a rule that any
modifications under the .github/workflows/ path and any setup scripts must have
approval from designated owners; specify the default reviewer group and user
(nickbianchi and ChittyOS/cicd-admins) as required approvers in the policy text
and ensure the policy entry is placed alongside the existing PR and review
policy list so reviewers and CI admins are alerted for those high-impact
changes.
- Around line 42-47: Replace the vague governance bullet “Assume required status
checks, code scanning, and workflow gates are enforced” with an explicit list of
branch-protection requirements: require the status checks named "beacon-check",
"test", and "security" before merging; enable "Dismiss stale pull request
approvals" and "Require review from Code Owners"; and state that required check
contexts must match existing workflow names (do not add contexts that do not
exist on the base branch) and that protections remain in single-operator mode
even if approval count is 0. Update the Governance constraints section to
include these exact check names and the two review settings so the document is a
source-of-truth rather than an assumption.
Added governance and coding guidelines for production code in a multi-repo environment, covering priorities, security, quality, and review policies.
Summary by CodeRabbit