Merged
Conversation
Owner
chizmeeple
commented
Feb 3, 2026
chizmeeple
commented
- features
- Revised accelerate-time (skip-ahead) flow: skipped preset days are styled as past, hidden when not current, and correctly numbered when starting a new day with Wake Up
- improvements
- Sound choices in settings are now applied correctly; sound loading is more reliable
- Nominations countdown resets when starting a new day; wake-up countdown shortened to 6 seconds
- Timer display no longer flickers when reloading
|
chizmeeple
force-pushed
the
change-accelerate-time-process
branch
from
5210c8a to
f138062
Compare
Summary of what was wrong and what was changed: Cause: On load the app does two things in order: In the DOMContentLoaded handler it creates the sound Audio objects using the default filenames (Cathedral Bells and Chisel Bell). Later it calls loadSettings(), which reads your saved choices from localStorage and updates the variables and the UI (so the dropdowns showed “Single Church Bell” and “Quick Bell”), but it did not create new Audio objects from those values. So the variables and the form were correct, but endSound and wakeUpSound were still the original Audio instances pointing at the default files. Fix: In loadSettings(), when there are saved settings, the code now recreates the three sound Audio objects after applying the parsed settings, so they use the loaded endOfDaySound, wakeUpSoundFile, and nominationsOpenSoundFile. That way the sounds that play match what’s saved and what you see in Settings. After a refresh, the end-of-day and wake-up sounds should be the ones you saved (e.g. Single Church Bell and Quick Bell). No need to change settings again.
chizmeeple
force-pushed
the
change-accelerate-time-process
branch
from
dff9f2f to
7ef6aec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.