Skip to content

Support flexible configuration formats in filesystem mount parser#25

Merged
JohnAmadis merged 3 commits intomasterfrom
copilot/fix-filesystem-mount-issue
Feb 7, 2026
Merged

Support flexible configuration formats in filesystem mount parser#25
JohnAmadis merged 3 commits intomasterfrom
copilot/fix-filesystem-mount-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 7, 2026

Configuration parser rejected addr=0x80303F1,size=0 (short keys, comma-separated) causing mount failures with "Unknown config key" warnings. Parser only accepted flash_addr=X;flash_size=Y format.

Changes

  • Parser accepts short and long key names: addr/flash_addr, size/flash_size
  • Parser accepts comma or semicolon separators: , and ;
  • Updated documentation with supported format variants

Example

All formats now work:

// Original (still supported)
dmfsi_dmffs_init("flash_addr=0x08080000;flash_size=0x80000");

// User's format (now supported)
dmfsi_dmffs_init("addr=0x80303F1,size=0");

// Mixed variants
dmfsi_dmffs_init("addr=0x08080000;size=0x80000");
dmfsi_dmffs_init("flash_addr=0x08080000,flash_size=0x80000");

Parser implementation in parse_config_string() now checks key length and compares against both variants before accepting/rejecting keys.

Original prompt

This section details on the original issue you should resolve

<issue_title>Problem z montowaniem systemu plików</issue_title>
<issue_description>jest jakiś problem z montowaniem tego systemu plików, w dmod-boot mam:

[WARN] Flash address not configured. 'FLASH_FS_ADDR' variable is not set (hex value required)
[WARN] Flash size not configured. 'FLASH_FS_SIZE' variable is not set (hex value required)
[INFO] Module enabled: dmffs
[WARN] Unknown config key: '%.*s'
[INFO] File system 'dmffs' mounted at '/configs' successfully
[ERROR] Failed to mount config filesystem at /configs/

Czyli niby się udalo a potem jest fail. W systemie plikow tez nie jest widoczny - no i ten warning jest dziwny. Opcje przekazane do montowania to:
addr=0x80303F1,size=0</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits February 7, 2026 18:34
…/semicolon separators

Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issue with mounting file system in dmod-boot Support flexible configuration formats in filesystem mount parser Feb 7, 2026
Copilot AI requested a review from JohnAmadis February 7, 2026 18:37
@JohnAmadis JohnAmadis marked this pull request as ready for review February 7, 2026 18:49
@JohnAmadis JohnAmadis merged commit de22b6d into master Feb 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem z montowaniem systemu plików

2 participants