feat: support custom LinearGradient component via prop#154
Open
androxxe wants to merge 1 commit intochramos:masterfrom
Open
feat: support custom LinearGradient component via prop#154androxxe wants to merge 1 commit intochramos:masterfrom
androxxe wants to merge 1 commit intochramos:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users of Expo (or any other environment) cannot use this library out of the box
because it hardcodes
react-native-linear-gradient, which is not compatible withExpo's
expo-linear-gradient.Solution
Accept a
LinearGradientcomponent as a prop, allowing users to pass any compatiblegradient library. Defaults to
react-native-linear-gradientso existing usage isfully backwards compatible.
Usage (Expo)