Skip to content

Adding testID prop #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeanwire wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding testID prop #71

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18a13fd
updating changes
Dec 21, 2022
4b1eae5
also add testID to view used for setLayout
Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/skeleton-placeholder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ type SkeletonPlaceholderProps = {
* Determines width of the highlighted area
*/
shimmerWidth?: number;
testID?: string;
};

type SkeletonPlaceholderItemProps = ViewStyle & {
Expand All @@ -68,6 +69,7 @@ const SkeletonPlaceholder: React.FC<SkeletonPlaceholderProps> & {
direction = 'right',
borderRadius,
shimmerWidth,
testID,
}) => {
const [layout, setLayout] = React.useState<LayoutRectangle>();
const animatedValueRef = React.useRef(new Animated.Value(0));
Expand Down Expand Up @@ -125,13 +127,13 @@ const SkeletonPlaceholder: React.FC<SkeletonPlaceholderProps> & {
if (!enabled || !placeholders) return children;

if (!layout?.width || !layout.height)
return <View onLayout={(event) => setLayout(event.nativeEvent.layout)}>{placeholders}</View>;
return <View testID={testID} onLayout={(event) => setLayout(event.nativeEvent.layout)}>{placeholders}</View>;

// https://github.com/react-native-linear-gradient/react-native-linear-gradient/issues/358
// to make transparent gradient we need to use original color with alpha

return (
<MaskedView style={{height: layout.height, width: layout.width}} maskElement={placeholders}>
<MaskedView testID={testID} style={{height: layout.height, width: layout.width}} maskElement={placeholders}>
<View style={[StyleSheet.absoluteFill, {backgroundColor}]} />

{isAnimationReady && highlightColor !== undefined && transparentColor !== undefined && (
Expand Down