Use xcode-select -p as a base path to xcode-git#1
Open
p4checo wants to merge 1 commit into
Open
Conversation
The `git` script assumed it was always run from `<Xcode dir>/usr/bin` and as such used `$(dirname $0)` as a base path to point to the original Xcode git binary. However, that's not always the case as there are other places that symlink to Xcode's `/usr/bin/git`, like `<Xcode dir>/usr/libexec/git-core/git`, meaning that any operation that used these links would fail. By using the `xcode-select -p` path as a base path to the Xcode directory this is fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
gitscript assumed it was always run from<Xcode dir>/usr/binand as such used$(dirname $0)as a base path to point to the original Xcode git binary.However, that's not always the case as there are other places that symlink to Xcode's
/usr/bin/git, like<Xcode dir>/usr/libexec/git-core/git, meaning that any operation that used these links would fail.By using the
xcode-select -ppath as a base path to the Xcode directory this is fixed.PS: Thanks for making this! 🙌