Fixes & updates for compass-sinatra sample project#1
Open
adamesque wants to merge 6 commits into
Open
Conversation
…lear when to use configure at all)
…if the compiled css is availabe statically, the scss source will never be recompiled.
…blic_folder instead
:public is no longer used to avoid overloading Module#public
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Chris,
Here's a handful of fixes to hopefully make this Sinatra sample project a little easier to get started with.
Removing the compiled css file from /static is probably the most helpful change, because if it's present, Sinatra will serve that instead of recompiling the source sass file.
The other potentially helpful change swaps out sass syntax for scss. Not only do most of the tutorials these days seem to use scss, but I, uh, couldn't even get the sass version working. That might just be me not being familiar enough with sass to update it properly.
The other changes are mostly cosmetic.
Left unresolved by this pull request:
compass compilewill once again prevent Sinatra from ever recompiling, by regenerating the static fileThanks,
Adam