Fix compatibility issue for Windows (Issue#1).#4
Open
richc7 wants to merge 1 commit into
Open
Conversation
Replace "which" command with "where" for Windows instances. Fixes chriseppstein#1. "By default, the search is done along the current directory and in the paths specified by the PATH environment variable" (from "where" command-line help). In some cases, this fails to find a Java installation located on a different drive than the drive from which the validator is being called. To counter this, this code adds a second "where" call with the C:\ path hard-coded should the default search path(s) fail. This hard-coded path should eventually be converted to a configuration value to allow override. Tested successfully on Windows Server 2012 R2 Standard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace "which" command with "where" for Windows instances. Fixes #1.
"By default, the search is done along the current directory and in the paths specified by the PATH environment variable" (from "where" command-line help). In some cases, this fails to find a Java installation located on a different drive than the drive from which the validator is being called. To counter this, this code adds a second "where" call with the C:\ path hard-coded should the default search path(s) fail. This hard-coded path should eventually be converted to a configuration value to allow override.
Tested successfully on Windows Server 2012 R2 Standard.