Skip to content

feat(members): make youth leader group name configurable#261

Open
chrisflav wants to merge 4 commits intochrisflav:mainfrom
chrisflav-agents:feat/issue-231-youth-leader-group
Open

feat(members): make youth leader group name configurable#261
chrisflav wants to merge 4 commits intochrisflav:mainfrom
chrisflav-agents:feat/issue-231-youth-leader-group

Conversation

@chrisflav
Copy link
Copy Markdown
Owner

Summary

Implements #231.

  • Adds YOUTH_LEADER_GROUP config variable (defaults to "Jugendleiter") in settings/local.py, configurable via misc.youth_leader_group in settings.toml
  • Replaces all hardcoded "Jugendleiter" group name lookups in members/admin.py, mailer/management/commands/reply_addrs.py, and members/management/commands/get_assoc_addr.py / get_forward_addrs.py with settings.YOUTH_LEADER_GROUP
  • Adds a data migration (0048_create_youth_leader_group) that automatically creates the group on first migration
  • Forbids deletion of the youth leader group via GroupAdmin.has_delete_permission and delete_queryset
  • Documents the config variable in deploy/config/settings.toml as a commented-out example

Test plan

  • Run existing tests to verify no regressions
  • Verify that after migration the Jugendleiter group is created automatically
  • Try deleting the youth leader group via admin — should be blocked
  • Set youth_leader_group = 'MyGroup' in settings.toml, create that group, and confirm the admin forms filter by it correctly

🤖 Generated with Claude Code

Add a YOUTH_LEADER_GROUP config variable (defaults to "Jugendleiter")
to replace all hardcoded group name references. The group is automatically
created during migration, and deletion is forbidden via the admin.

Closes chrisflav#231

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 26, 2026

📚 Documentation deployed!

Documentation: https://chrisflav.github.io/kompass/feat/issue-231-youth-leader-group/

Docker Images:

  • App: ghcr.io/chrisflav/kompass:pr-261
  • Nginx: ghcr.io/chrisflav/kompass-nginx:pr-261

Add the awaiting-deployment label to deploy this PR to a staging server.

chrisflav-agent Bot and others added 3 commits April 26, 2026 23:48
The data migration that pre-creates the youth leader group changes group
PKs relative to other groups created during CSV import. Sort groups by
name when exporting to ensure a stable, PK-independent order, and update
the test fixture accordingly.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sort all multi-group fields alphabetically to match the order_by("name")
used in CSV export.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@chrisflav chrisflav linked an issue Apr 27, 2026 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handling of Jugendleiter group

1 participant