Skip to content

feat(members): show warning instead of error when inviting to group without contact email#283

Open
chrisflav wants to merge 5 commits intochrisflav:mainfrom
chrisflav-agents:feature/waiting-list-no-contact-email
Open

feat(members): show warning instead of error when inviting to group without contact email#283
chrisflav wants to merge 5 commits intochrisflav:mainfrom
chrisflav-agents:feature/waiting-list-no-contact-email

Conversation

@chrisflav
Copy link
Copy Markdown
Owner

Summary

Closes #264

  • Replace the plain error message (redirect with flash) with an intermediate warning view when an admin tries to invite a waiting list member to a group that has no contact email configured
  • The warning view explains the missing contact email and recommends configuring one first, with a checkbox the admin must tick to acknowledge and proceed
  • Once confirmed, the invitation proceeds normally but without CC (fixed AttributeError on group.contact_email.email when contact_email is None)
  • Also fixed group.get_invitation_text_template() to gracefully handle None contact email (formats as empty string instead of None)

Test plan

  • Invite a waiter to a group with contact email → behavior unchanged (text form shown directly)
  • Invite a waiter to a group without contact email → warning view shown with checkbox disabled proceed button
  • Tick the checkbox → proceed button enabled; click Proceed → text form shown
  • Click Send → invitation email sent without CC
  • Existing tests pass (test_invite_view, test_ask_for_registration_action)

🤖 Generated with Claude Code

…ithout contact email

When an admin tries to invite a waiting list member to a group that has no
contact email configured, show an intermediate warning view with a checkbox
to acknowledge the missing contact email, rather than a plain error message
and redirect. If confirmed, the invitation proceeds without a CC email.

Closes chrisflav#264

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2026

📚 Documentation: https://chrisflav.github.io/kompass/feature/waiting-list-no-contact-email/

Docker Images:

  • App: ghcr.io/chrisflav/kompass:pr-283
  • Nginx: ghcr.io/chrisflav/kompass-nginx:pr-283

Add the awaiting-deployment label to deploy this PR to a staging server.

chrisflav-agent Bot and others added 4 commits May 3, 2026 21:57
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…irmation page

The jet admin CSS hides the native checkbox and renders a custom checkmark
via `input[type=checkbox] + label:before`, which requires the label to be
a sibling after the input. The input was wrapped inside the label, so the
selector never matched and no checkmark was rendered.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enable invitation from waiting list to group without contact email of group

1 participant