[ENH](foundation-api): harden wiki apply-patch and trajectory writes#7441
Open
rescrv wants to merge 1 commit into
Open
[ENH](foundation-api): harden wiki apply-patch and trajectory writes#7441rescrv wants to merge 1 commit into
rescrv wants to merge 1 commit into
Conversation
Self-review pass on the atomic wiki apply-patch flow: - Allow the empty root slug in read-page requests and cover it in citation, file round-trip, and open-trajectory append tests. - Keep page-chunk reads within the Chroma Cloud Get limit of 300. Detect oversized existing pages with a follow-up one-row read at the overflow offset instead of requesting limit=301. - Map wrapped Chroma client errors to precise ErrorCodes in TrajectoryError, translating conditional-write conflicts to FailedPrecondition and validation errors to InvalidArgument. - Log apply-patch and upsert-page failures with tenant, slug, and error code, and instrument the run helpers for tracing. Co-authored-by: AI
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Contributor
|
Found 1 test failure on Blacksmith runners: Failure
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Self-review pass on the atomic wiki apply-patch flow:
Allow the empty root slug in read-page requests and cover it in
citation, file round-trip, and open-trajectory append tests.
Keep page-chunk reads within the Chroma Cloud Get limit of 300.
Detect oversized existing pages with a follow-up one-row read at the
overflow offset instead of requesting limit=301.
Map wrapped Chroma client errors to precise ErrorCodes in
TrajectoryError, translating conditional-write conflicts to
FailedPrecondition and validation errors to InvalidArgument.
Log apply-patch and upsert-page failures with tenant, slug, and
error code, and instrument the run helpers for tracing.
Test plan
CI + local ingest passed
Migration plan
N/A
Observability plan
N/A
Documentation Changes
N/A
Co-authored-by: AI