Skip to content

[ENH](log-service): surface LogContentionRetry as backoff#7445

Open
rescrv wants to merge 1 commit into
make-trajectories-work2from
make-trajectories-work3
Open

[ENH](log-service): surface LogContentionRetry as backoff#7445
rescrv wants to merge 1 commit into
make-trajectories-work2from
make-trajectories-work3

Conversation

@rescrv

@rescrv rescrv commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Description of changes

Map wal3::Error::LogContentionRetry to a ResourceExhausted status
carrying a "contention" backoff-reason so clients back off on
contention the same way they do on batching backpressure.

Test plan

CI + things behave better locally

Migration plan

N/A

Observability plan

N/A

Documentation Changes

N/A

Co-authored-by: AI

Map wal3::Error::LogContentionRetry to a ResourceExhausted status
carrying a "contention" backoff-reason so clients back off on
contention the same way they do on batching backpressure.

Co-authored-by: AI

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@github-actions

Copy link
Copy Markdown

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@blacksmith-sh

blacksmith-sh Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
test_count_to_file_async_attached_function_counts_late_inputs View Logs

Blacksmith runners detected OOM events on the following jobs:

Job Details
Rust tests / Integration test ci_k8s_integration 1 View Job
Python tests / test-cluster-rust-frontend (3.9, chromadb/test/property/test_collections_with_database_tenant_ove... View Job

Fix in Cursor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant