Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

Support VS 2019 from Native Tools Command Prompt.#3

Open
john-preston wants to merge 1 commit into
chromium:masterfrom
telegramdesktop:tdesktop
Open

Support VS 2019 from Native Tools Command Prompt.#3
john-preston wants to merge 1 commit into
chromium:masterfrom
telegramdesktop:tdesktop

Conversation

@john-preston

Copy link
Copy Markdown

Right now GYP isn't detecting VS 2019 if only it is installed in the system (without VS 2017 or earlier).

This PR allows GYP to work from one of the provided batch environments (like "x86 Native Tools Command Prompt for VS2019").

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@john-preston

Copy link
Copy Markdown
Author

@googlebot I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants