⚡ Optimize N+1 query in room availability dashboard#10
Conversation
Replaced N+1 iteration over rooms with single batched queries using `IN` clause with room_ids via `sqlx::QueryBuilder`. Added two queries to retrieve `active` and `booked` status, reducing 2N + 1 queries down to 3 overall. Reduced baseline bench test from 650+ ms per iteration down to 30ms or less. Co-authored-by: chuanman2707 <29907469+chuanman2707@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Replaced N+1 iteration over rooms with single batched queries using `IN` clause with room_ids via `sqlx::QueryBuilder`. Added two queries to retrieve `active` and `booked` status, reducing 2N + 1 queries down to 3 overall. Reduced baseline bench test from 650+ ms per iteration down to 30ms or less. Also addressed a clippy warning `clippy::unnecessary-sort-by` in `mhm/src-tauri/src/commands/groups.rs` which broke the CI check suite. Co-authored-by: chuanman2707 <29907469+chuanman2707@users.noreply.github.com>
|
The batching change in |
I have isolated the optimization into a tighter diff by reverting the unrelated formatting/clippy changes in |
… in room availability dashboard Replaced N+1 iteration over rooms with single batched queries using `IN` clause with room_ids via `sqlx::QueryBuilder`. Added two queries to retrieve `active` and `booked` status, reducing 2N + 1 queries down to 3 overall. Reduced baseline bench test from 650+ ms per iteration down to 30ms or less. Reverted unnecessary changes in `mhm/src-tauri/src/commands/groups.rs` as it was unrelated to this specific feature PR. Co-authored-by: chuanman2707 <29907469+chuanman2707@users.noreply.github.com>
Replaced `sort_by(|a, b| b.1.len().cmp(&a.1.len()))` with `sort_by_key(|b| std::cmp::Reverse(b.1.len()))` to fix a clippy warning `clippy::unnecessary-sort-by` in `mhm/src-tauri/src/commands/groups.rs` which broke the CI check suite. Co-authored-by: chuanman2707 <29907469+chuanman2707@users.noreply.github.com>
1 participant
💡 What: The optimization implemented is refactoring
do_get_rooms_availabilityto replace iterating overroom_rowsand running two specific queries per room, to running batched queries using theINclause for allroom_ids. It utilizessqlx::QueryBuilderand places results in a HashMap to look them up by room id in memory later.🎯 Why: To improve performance and eliminate N+1 query inefficiency which resulted in 2N + 1 queries. With the change it is now exactly 3 queries.
📊 Measured Improvement: The
do_get_rooms_availabilitytook ~650+ ms per iteration in testing with 500 rooms. With the optimized approach usingcargo run --release, it reduced to less than ~30 ms, proving the performance impact.PR created automatically by Jules for task 17419733329401003272 started by @chuanman2707