Skip to content

🧪 Add state management tests for useHotelStore#13

Open
chuanman2707 wants to merge 3 commits into
mainfrom
testing-use-hotel-store-13810137760556023977
Open

🧪 Add state management tests for useHotelStore#13
chuanman2707 wants to merge 3 commits into
mainfrom
testing-use-hotel-store-13810137760556023977

Conversation

@chuanman2707
Copy link
Copy Markdown
Owner

🎯 What: Added tests for useHotelStore's core functionality.
📊 Coverage: Tests verify the initial state, fetchRooms, fetchStats, checkIn (success/error), and checkOut (success/error). Uses mocks for Tauri's invoke API.
Result: Increased store test coverage and ensures core state mutations from Tauri commands work seamlessly.


PR created automatically by Jules for task 13810137760556023977 started by @chuanman2707

Co-authored-by: chuanman2707 <29907469+chuanman2707@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cbb7064281

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +7 to +10
beforeEach(() => {
clearMockResponses();
invoke.mockClear();
});
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reset store state before each test

useHotelStore is a singleton Zustand store, but this beforeEach only clears mocked invoke handlers and never restores store state. Because tests like fetchRooms, checkIn, and checkOut mutate global store fields, later tests can inherit prior state and either fail intermittently or pass while missing regressions (for example, activeTab assertions can stay green simply because the previous/default value is already "dashboard"). Add a useHotelStore.setState(...) reset to the initial state in beforeEach to keep tests isolated.

Useful? React with 👍 / 👎.

Co-authored-by: chuanman2707 <29907469+chuanman2707@users.noreply.github.com>
Copy link
Copy Markdown
Owner Author

The store test coverage is valuable, but I’m holding merge on this revision. The PR brings more dependency/lockfile churn than needed, and I’d like the test isolation tightened before merging. Please recut it as a cleaner store-test-only PR.

Co-authored-by: chuanman2707 <29907469+chuanman2707@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant