Skip to content

ui: improve layout spacing and window dimensions#17

Open
hoangnv170752 wants to merge 1 commit into
chuanman2707:mainfrom
hoangnv170752:main
Open

ui: improve layout spacing and window dimensions#17
hoangnv170752 wants to merge 1 commit into
chuanman2707:mainfrom
hoangnv170752:main

Conversation

@hoangnv170752
Copy link
Copy Markdown

Summary

  • Fix UI layout issues: prevent window from being resized too small and improve content spacing.

What Changed

  • Set minimum window size (1024×700) to prevent layout breakage on small screens
  • Increased default window size to 1280×800 for better initial experience
  • Added top padding to main content area
  • Added padding to SlideDrawer body so section titles are not flush against edges
  • Fixed service form grid alignment in GroupManagement page

Verification

npm run tauri dev
npm test
npm run build

Risks / Follow-up

  • None

@chuanman2707
Copy link
Copy Markdown
Owner

chuanman2707 commented Apr 18, 2026

Code review (updated)

Found 1 issue:

  1. SlideDrawer giờ luôn bọc {children} bằng flex-1 overflow-y-auto p-6, thay đổi contract của component từ "caller tự render body" sang "component luôn bọc". Hậu quả: các caller hiện có đã tự wrap sẽ bị double padding + nested overflow-y-auto. Ít nhất 3 chỗ regress:

Điểm thay đổi trong PR: SlideDrawer.tsx#L55-L61

Cách xử lý an toàn hơn: giữ SlideDrawer như cũ và chỉ thêm padding ở caller cần (GroupManagement), hoặc thêm prop opt-in (vd. padded / bodyClassName) thay vì ép mặc định cho mọi drawer.

Note: bản review trước của tôi đã bỏ sót issue này. Cảm ơn Codex đã catch.

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants