Open
Conversation
Signed-off-by: Bobby Tjassens Keiser <bobby.tjassens.keiser@y-innovate-it.com>
Member
|
Hi @Y-Innovate Thanks for the input. Let me page this repo back into memory and I'll take a look later this week. Ian |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Ian,
I came across your repo searching for a way to Base64 encode and decode in Assembler and your code is simply wonderful. I very much appreciate you sharing this freely on Github.
I ran into what I think is a little bug and made a suggestion in the form of a pull request. I'm not 100% sure, but I think it's better in base64d.asm to test the yet undecoded character in R1 for '=' instead of the decoded char in R3.
Cheers!
Bobby