Implement cone-beam geometry calibration#21
Merged
Merged
Conversation
Obi-Wan
changed the title
Obi-Wan
force-pushed
the
cone_beam_calib
branch
from
1354d34 to
360598c
Compare
Obi-Wan
force-pushed
the
cone_beam_calib
branch
from
360598c to
a8579c9
Compare
Collaborator
Author
|
The recent round of updates includes a few fixes, better presentation of the results, and cleaner code. I'm also adding unit tests to spot possible errors or regressions. The current coverage is incomplete, but the bulk of the work has been done. Documentation will come at last. |
Signed-off-by: Nicola VIGANO <nicola.vigano@esrf.fr>
Signed-off-by: Nicola VIGANO <nicola.vigano@esrf.fr>
Signed-off-by: Nicola VIGANO <nicola.vigano@esrf.fr>
Signed-off-by: Nicola VIGANO <nicola.vigano@esrf.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
…ng function Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
…es positions Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
Collaborator
Author
|
Documentation, unit tests, and an example are now in place. I will now proceed to merge this into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cone-beam geometries present more degrees of freedom than parallel-beam geometries. In this PR, we implement the protocol for calibrating cone-beam geometries described in [1]. This extends the use of this library outside synchrotron tomography. This PR also introduces a more general fiducial-marker tracking code, that could be used for refined calibration of other geometries.
TODO
Notes
This procedure is based on sampling one fiducial marker over two off-axis and off-plane rotations.
[1] Noo, F., Clackdoyle, R., Mennessier, C., White, T. A. & Roney, T. J. (2000). Phys. Med. Biol. 45, 3489–3508. doi: 10.1088/0031-9155/45/11/327