Improve parameter tuning#25
Merged
Merged
Conversation
…panded API. Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
…nting Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
…ction Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Collaborator
Author
|
We should probably use this PR to also add decent documentation for this feature. |
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola VIGANÒ <nicola.vigano@cea.fr>
Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
…putation Signed-off-by: Nicola Vigano <nicola.vigano@cea.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hyperparameter tuning is fundamental for obtaining good reconstructions when using regularizations.
corrctcurrently offers support for single hyperparameter tuning, based on the L-curve and cross-validation methods. However, with growing needs for other work distribution tools than the basicThreadPoolExecutor, the current API and infrastructure are inadequate to support further developments. This PR cleans the API, while making it more flexible and transparent. It also refactors internal code to use a more structured and scalable approach (using simpler functions and fewer nested class methods). Finally, this PR also introduces simple support for K-fold cross-validation and tracking performance metrics of the reconstructions.TODO
initandexecfunctionsinitfunctionOptional: add support for variadic return arguments for theinitfunctionNotes
Performance metrics and all reconstructions are currently only returned when requested with the
return_allargument set toTrue. This should reduce memory usage when those features are not necessary.