ci: vitest contract tests, ci workflow, status badges#27
Merged
Conversation
- src/data/releases.test.ts: consumer-side contract tests for the generated releases.json (ISO releaseAt, hyperfollow href + ?ref=release, slug(title) == hyperfollow slug so funnel attribution can't silently break, cover URL shape, uniqueness) + links.ts platform stack checks - .github/workflows/ci.yml: astro check -> vitest -> astro build on every push/PR - pin vite@^6 as a devDep so vitest and astro share one vite (vitest otherwise hoists vite 7 and astro check fails on the tailwind plugin type skew) - README: ci/license/astro badges + dev docs for the test commands Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
src/data/releases.test.ts— consumer-side contract tests (29) for the generatedreleases.json+links.ts:releaseAtis ISO-8601 with explicit offset and parseshrefis a hyperfollow link carrying?ref=releaseattributionslug(title)== hyperfollow slug — guards funnel attribution (thedata-releasestamp must match the opsrelease_id)/covers/*.webpor remote https), uniqueness, lowercase voice.github/workflows/ci.yml—astro check→vitest run→astro buildon every push/PRvite@^6pinned as devDep — vitest otherwise hoists vite 7 next to astro's vite 6 andastro checkfails on a tailwind-plugin type skew (verified: main is clean, the skew only appears with two vite copies)verification
Local:
astro check0 errors · 29/29 tests pass · build complete.🤖 Generated with Claude Code