test(types): add unit tests for PruningConfig enabled and effective_min_height#61
Open
lau90eth wants to merge 1 commit into
Open
test(types): add unit tests for PruningConfig enabled and effective_min_height#61lau90eth wants to merge 1 commit into
lau90eth wants to merge 1 commit into
Conversation
f48699a to
efa1b1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add unit tests for
PruningConfigto improve test coverage.The
PruningConfigstruct had 0% test coverage. These tests verify:enabled()returnsfalseby defaultenabled()returnstruewhencertificates_distance > 0enabled()returnstruewhencertificates_before > Height::new(0)effective_certificates_min_height()preferscertificates_beforeovercertificates_distanceeffective_certificates_min_height()correctly subtracts distance from current heighteffective_certificates_min_height()saturates at zero when distance exceeds current heighteffective_certificates_min_height()returns zero when pruning is disabledTesting
cargo test -p arc-consensus-types
All 31 tests pass.