test(evm-node): add unit tests for rpc_get_version#62
Open
lau90eth wants to merge 1 commit into
Open
Conversation
lau90eth
force-pushed
the
lau90eth/test-rpc-get-version-v2
branch
2 times, most recently
from
81976b4 to
d5e169b
Compare
lau90eth
force-pushed
the
lau90eth/test-rpc-get-version-v2
branch
from
d5e169b to
33e37b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add unit tests for
rpc_get_version()inevm-node/src/rpc/get_version.rs.The function had 0% test coverage. These tests verify:
rpc_get_version()returnsOkgit_version,git_commit,git_short_hash,cargo_version) are non-emptygit_short_hashis a prefix ofgit_commitcargo_versioncontains the short hashTesting
cargo test -p arc-evm-node
52 tests pass.