Skip to content

minor refactor to use implemented deref trait #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ikwuoz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

minor refactor to use implemented deref trait #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/eth-engine/src/engine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ impl Engine {
/// Stays pending forever for non-IPC engines (RPC, mock), so calling code can
/// unconditionally `select!` on this without special-casing the transport.
pub async fn wait_for_disconnect(&self) {
match &self.0.disconnect_rx {
match &self.disconnect_rx {
// wait_for checks the current value first, so late subscribers see a prior disconnect.
Some(rx) => {
rx.clone().wait_for(|&v| v).await.ok();
Expand All @@ -188,7 +188,7 @@ impl Engine {
/// The provided function should use the same chainspec as the EL so that
/// the V4/V5 decision always aligns.
pub fn set_is_osaka_active(&self, f: IsOsakaActiveFn) {
if self.0.is_osaka_active.set(f).is_err() {
if self.is_osaka_active.set(f).is_err() {
tracing::warn!("Osaka activation function already set; ignoring duplicate call");
}
}
Expand Down Expand Up @@ -262,7 +262,7 @@ impl Engine {
/// if one was configured. `None` for test/mock engines or RPC without
/// `--execution-ws-endpoint`.
pub fn subscription_endpoint(&self) -> Option<&SubscriptionEndpoint> {
self.0.subscription_endpoint.as_ref()
self.subscription_endpoint.as_ref()
}
}

Expand Down