Ensure html attributes are escaped in templates#7
Open
colemanw wants to merge 1 commit intocircleinteractive:masterfrom
Open
Ensure html attributes are escaped in templates#7colemanw wants to merge 1 commit intocircleinteractive:masterfrom
colemanw wants to merge 1 commit intocircleinteractive:masterfrom
Conversation
This adds escape='htmlattribute' to all translations within tags, which ensures any special characters in the translated string are properly escaped and don't break out of the quotes or cause other problems. See civicrm/civicrm-core#26792 Note: This requires CiviCRM 5.65 at minimum.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds escape='htmlattribute' to all translations within tags, which ensures any special characters in the translated string
are properly escaped and don't break out of the quotes or cause other problems.
See civicrm/civicrm-core#26792
Note: This requires CiviCRM 5.65 at minimum.