Add ASCON

[xmamalou]

Add handling for ASCON

[abkarcher]

Hello,
Thank you for the contribution! Before I take a look at this, could you please remove the formatting/style changes unrelated to ASCON, and ensure consistent code style is used in the ASCON additions?

And then, if you could base this from the "libacvp_2_3_0-throttle" branch instead of main, that would be needed too.

Thanks again,
Andrew

[xmamalou]

Hello, sorry for the long wait.

I have done the changes as requested. Sorry again for the formatting, Emacs was more zealous with the autoformatting than I expected and I hadn't noticed it had changed the entire file.

Best regards,
Christoforos

[abkarcher]

Thanks! Taking a look now.

[abkarcher]

Thank you! I pulled a branch from this PR to do some more testing, and noted a few more things.

• I am hitting ACVP_INVALID_ARG errors when trying to build a registration for all ASCON algs. Something about acvp_cap_ascon_set_domain() is not functioning as expected. Instead of using switch case fall-throughs, can we restructure this to handle each PARM value for each cipher, similar to other algorithms?
• I do not think the ACVP_ASCON_MODE parameters or enums are needed; in each case we always have the ACVP_CIPHER value, unless I am mistaken
• The set_parm() and set_domain() ascon APIs for setting values should have bounds checks against ASCON_*_MAX values in acvp_lcl.h.
• Nit: (Sorry for not catching this the first go around): can we rename the ASCON params to have "parm" in the middle instead of the end? e.g. instead of ACVP_ASCON_PAYLEN_PARM, maybe ACVP_ASCON_PARM_PAYLEN? to be more consistent with other algorithms

[xmamalou]

Hello! I have implemented the changes you have requested.

[abkarcher]

Hello,

I hit an issue where XOF128 mode does not build the correct JSON in the registration (missing messageLength) because the wrong array is referenced in the JSON builder for XOF128. There are also valgrind warnings related to this.

There are build warnings, mostly related to casting and const removal, in acvp_ascon.c that also should be addressed.
(-Wpointer-sign, -Wdiscarded-qualifiers, -Wreturn-type)

Thanks,
Andrew