Version fix and arg passing correction on options#21
Open
amirali-ashraf wants to merge 2 commits intocivisanalytics:masterfrom
Open
Version fix and arg passing correction on options#21amirali-ashraf wants to merge 2 commits intocivisanalytics:masterfrom
amirali-ashraf wants to merge 2 commits intocivisanalytics:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have faced a conflict few days ago with using the API wrapper.
So, I used
>=for rubyzip library and also the ruby version to allow me use the library in ruby3.1.0. I run the tests on the environment but maybe you need to rerun the tests on2.1.0and2.4.10to make sure if it is not breaking anything.Thanks