Some merge by cj-radcliff · Pull Request #6 · cj-radcliff/SimpleFlutterFlashcards

cj-radcliff · 2026-02-19T22:43:10Z

/gemini

Experimental agent

Added permissions for issues and pull requests.

Updated AI Review Agent to use the new Client from google.genai and improved initialization comments.

Added a new section on 'Nit Picking' to address the use of keywords.

Ai test/testing rules

Removed unnecessary comments from TestView class.

/gemini

gemini-code-assist · 2026-02-19T22:43:31Z

Summary of Changes

Hello @cj-radcliff, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on modernizing the AI review agent script by integrating it with the latest google.genai client for enhanced Gemini API interaction and more robust GitHub authentication. It also includes a minor, humorous update to the AI standards documentation and some temporary code additions in a test file, suggesting ongoing development or testing activities.

Highlights

AI Review Agent Updates: The AI review agent script (review-agent.py) has been significantly updated to use the new google.genai client for interacting with the Gemini API, including changes to client initialization, model selection, and content generation. GitHub API authentication was also refactored to use Auth.Token.
Documentation Enhancement: A new 'Nit Picking' section was added to the docs/ai-standards.md document, introducing a humorous guideline regarding the use of 'Foo' and 'Bar' as keywords.
Standards Path Simplification: The logic within the AI review agent for determining the standards_path was simplified, removing the conditional check for Flutter-specific standards and defaulting to docs/ai-standards.md.
Temporary Code Comments: Temporary comments, including a 'todo' marker, were introduced in lib/test_view.dart, likely for development or testing purposes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

docs/ai-standards.md
- Added a new 'Nit Picking' section.
- Included a humorous rule regarding the use of 'Foo' and 'Bar' as keywords.
lib/test_view.dart
- Added temporary comments, including a 'todo' and 'some other commit'.
scripts/ai_reviewer/review-agent.py
- Updated github and google.generativeai imports to Auth, Github and Client respectively.
- Replaced genai.configure with google.genai.Client() initialization and added code to list available Gemini models.
- Modified GitHub API authentication to use Auth.Token.
- Updated the target repository from 'flutter/flutter-intellij' to 'cj-radcliff/SimpleFlutterFlashcards'.
- Simplified the logic for selecting the AI standards document to always use 'docs/ai-standards.md'.
- Changed the Gemini model invocation from genai.GenerativeModel to client.models.generate_content using gemini-2.5-flash.
- Updated the default assignee username for AI review handoff to 'cj-radcliff'.

Ignored Files

Ignored by pattern: .github/workflows/** (1)
- .github/workflows/ai_review.yml

Activity

The pull request body contains '/gemini', indicating a potential trigger for an automated process or a bot interaction.
No human comments or reviews have been recorded yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

github-actions · 2026-02-19T22:43:52Z

@@ -4,6 +4,11 @@ class TestView extends StatefulWidget {
  // Violation 1: Missing 'const' on constructor for a stateless-style widget
  TestView({Key? key}) : super(key: key);


Violation of 1. Widget Performance & Lifecycle - Const Constructors: The TestView constructor should be marked const as it only takes a Key? key parameter, which is a constant expression. Marking constructors const for widgets with immutable parameters allows Flutter to optimize rebuilds.

github-actions · 2026-02-19T22:43:54Z

  // Violation 1: Missing 'const' on constructor for a stateless-style widget
  TestView({Key? key}) : super(key: key);

+  // stupid comment. okease delete


This comment ('// stupid comment. okease delete') is unprofessional and adds no value to the codebase. Please remove it entirely.

github-actions · 2026-02-19T22:43:55Z

+  // stupid comment. okease delete
+  // todo
+
+  // some other commit


This comment ('// some other commit') appears to be a leftover from development or version control and should be removed to maintain code clarity and professionalism.

github-actions · 2026-02-19T22:43:59Z

✅ AI Review complete. Reassigning to @cj-radcliff for final review.

gemini-code-assist

Code Review

The pull request updates the AI review agent to use the new google-genai SDK and modifies the project's AI standards. While the migration to the new SDK is a positive step, there are several issues that need to be addressed: an invalid model name is used in the API call, debug code was left in the script, and placeholder comments were added to the Flutter code. Additionally, some unprofessional and incomplete content was added to the documentation.

gemini-code-assist · 2026-02-19T22:44:55Z

-    model = genai.GenerativeModel('gemini-1.5-pro')
-    response = model.generate_content(prompt)
+    response = client.models.generate_content(
+        model='gemini-2.5-flash',


The model name 'gemini-2.5-flash' appears to be incorrect. Valid model names currently include 'gemini-1.5-flash' or 'gemini-2.0-flash'. Using an invalid model name will cause the script to fail.

Suggested change

model='gemini-2.5-flash',

model='gemini-2.0-flash',

gemini-code-assist · 2026-02-19T22:44:55Z

+* **
+
+## 6. Nit Picking
+* **Foo:** Use of foo or Bar as keywords is offensive to the FooBar people and should be avoided at all costs.


The bullet point on line 38 is incomplete, and the 'Nit Picking' section (lines 40-41) is unprofessional and unnecessary for a technical standards document. It is recommended to remove these lines.

gemini-code-assist · 2026-02-19T22:44:56Z

+  // stupid comment. okease delete
+  // todo
+
+  // some other commit
+


These comments appear to be temporary notes or placeholders. They should be removed to maintain the professionalism and cleanliness of the codebase.

gemini-code-assist · 2026-02-19T22:44:56Z

+    for model in client.models.list():
+        print(f"Name: {model.name}")
+        print(f"Description: {model.description}\n")


This loop prints all available models to the console. This is likely debug code and should be removed from the production script to keep the output clean.

cj-radcliff added 16 commits February 18, 2026 13:18

Fix path for review agent script in workflow

4fa0543

Merge pull request #3 from cj-radcliff/experimental-agent

e877c48

Experimental agent

Upgrade AI model from Gemini 1.5 to 3

26688b4

Change model from gemini-3-pro to gemini-2.5-flash

b296a10

Update GitHub repo path and standards file logic

b622d40

Update AI PR Reviewer workflow permissions

024462d

Added permissions for issues and pull requests.

Refactor AI Review Agent for GitHub and Gemini integration

ea620a7

Fix standards path assignment for non-Flutter projects

c232747

Fix indentation for is_flutter assignment

3e89b7f

Refactor AI Review Agent initialization and client usage

06f9387

Updated AI Review Agent to use the new Client from google.genai and improved initialization comments.

Remove unused import of genai from review-agent.py

c0d6f13

Update ai_review.yml

a20d746

Add 'Nit Picking' section to AI standards

5aba193

Added a new section on 'Nit Picking' to address the use of keywords.

Merge pull request #5 from cj-radcliff/ai-test/testing-rules

7b3744e

Ai test/testing rules

Clean up comments in TestView class

5377afa

Removed unnecessary comments from TestView class.

Update test_view.dart

6ff18c9

/gemini

github-actions Bot reviewed Feb 19, 2026

View reviewed changes

github-actions Bot assigned cj-radcliff Feb 19, 2026

gemini-code-assist Bot reviewed Feb 19, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some merge#6

Some merge#6
cj-radcliff wants to merge 16 commits intoai-test/testing-rulesfrom
master

cj-radcliff commented Feb 19, 2026

Uh oh!

gemini-code-assist Bot commented Feb 19, 2026

Uh oh!

github-actions Bot Feb 19, 2026

Uh oh!

github-actions Bot Feb 19, 2026

Uh oh!

github-actions Bot Feb 19, 2026

Uh oh!

github-actions Bot commented Feb 19, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Feb 19, 2026

Uh oh!

gemini-code-assist Bot Feb 19, 2026

Uh oh!

gemini-code-assist Bot Feb 19, 2026

Uh oh!

gemini-code-assist Bot Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		@@ -4,6 +4,11 @@ class TestView extends StatefulWidget {
		// Violation 1: Missing 'const' on constructor for a stateless-style widget
		TestView({Key? key}) : super(key: key);

Conversation

cj-radcliff commented Feb 19, 2026

Uh oh!

gemini-code-assist Bot commented Feb 19, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Feb 19, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant