Fix GIL handling in picosat memory allocators.#198
Open
ykazakov wants to merge 1 commit intocjdrake:mainfrom
Open
Fix GIL handling in picosat memory allocators.#198ykazakov wants to merge 1 commit intocjdrake:mainfrom
ykazakov wants to merge 1 commit intocjdrake:mainfrom
Conversation
The custom memory allocators in `picosatmodule.c` were calling PyMem_Malloc, PyMem_Realloc, and PyMem_Free without holding the GIL. This could lead to a segfault when picosat_sat, which releases the GIL, calls these allocators. This commit fixes the issue by acquiring the GIL before calling PyMem_ functions and releasing it afterwards in the custom memory allocators.
ykazakov
changed the title
ykazakov
changed the title
Author
|
The fix was generated using an AI tool (jules). I verified that it works for Python 3.12.2 and Python 3.13.5 (tests do not fail) on MacOS 18.5 (Macbook Pro M1), but I am not an expert on Python memory allocators. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom memory allocators in
picosatmodule.cwere calling PyMem_Malloc, PyMem_Realloc, and PyMem_Free without holding the GIL. This could lead to a segfault when picosat_sat, which releases the GIL, calls these allocators.This commit fixes the issue by acquiring the GIL before calling PyMem_ functions and releasing it afterwards in the custom memory allocators.
Fixes #195