log solrac version in solrac.boot#28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Today an operator looking at logs has no way to confirm which Solrac version a running process actually is —
package.jsonis shipped in the binary but never surfaced at runtime. This bit us in the v0.7.1 release thread: a user reported the harmony-token leak (fixed in #26) was still happening, and the only way to diagnose "are you on the binary that includes the fix?" was inference from tag dates. A version field in the boot log makes that one-liner clear.Change
src/main.ts:import packageJson from "../package.json"and addversion: packageJson.versionas the first field of the existingsolrac.bootinfo log.docs/CONFIG.md: matching"version": "0.7.1"line in the boot-log example JSON.bun build --compileembeds JSON imports, so the packaged binary's boot log carries whateverpackage.json.versionwas at build time — for tag-triggered builds that's the version the release flow just bumped to.Test plan
npm run typecheckcleansolrac.bootincludesversion: "0.7.1"(will verify post-merge with the next release)