Upgrade ESLint to v10#336
Draft
martnpaneq wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/ckeditor/ckeditor5-internal/issues/4327.
Upgrades ESLint from v9 to v10 and aligns the shared CKEditor 5 linter packages:
eslint→^10.0.0eslint-config-ckeditor5→^18.0.0(where used)eslint-plugin-ckeditor5-rules→^18.0.0(where used)Important
Blocked on the foundation release.
eslint-config-ckeditor5@18/eslint-plugin-ckeditor5-rules@18(ESLint 10 support) come from ckeditor/ckeditor5-linters-config#138 and are not published yet, so the lockfile cannot be regenerated and CI is expected to be red until that release lands. Once v18 is on npm, runpnpm installto update the lockfile, fix any new lint findings, and re-run CI.Lockfile intentionally not included in this commit for the reason above.