Skip to content

Revert "Fix inconsistent marker boundary order"#20075

Merged
pomek merged 1 commit intomasterfrom
revert-19995-ck/19975-marker-boundary-order
Apr 15, 2026
Merged

Revert "Fix inconsistent marker boundary order"#20075
pomek merged 1 commit intomasterfrom
revert-19995-ck/19975-marker-boundary-order

Conversation

@pomek
Copy link
Copy Markdown
Member

@pomek pomek commented Apr 15, 2026

Reverts #19995

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 103685c. Configure here.

},
triggerBy: {
attributes: [ 'toStyle', 'toClass' ]
},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test uses nonexistent triggerBy API property silently ignored

Low Severity

The triggerBy property passed to elementToElement() does not exist in its config type (model | view | converterPriority are the only accepted keys) and is silently ignored. The converter is configured with model: 'simpleBlock' (a plain string), so normalizeModelElementConfig produces an empty attributes array, meaning this converter registers no reconversion triggers. The tests still pass only because the beforeEach block already registers a separate converter with model: { name: 'simpleBlock', attributes: ['toStyle', 'toClass'] } whose reduceChanges handler remains active. The triggerBy property is dead code that misleadingly suggests it controls reconversion behavior.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 103685c. Configure here.

@pomek pomek merged commit ceeb695 into master Apr 15, 2026
12 checks passed
@pomek pomek deleted the revert-19995-ck/19975-marker-boundary-order branch April 15, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants