Skip to content

Added the ViewDocument#getRoots() method#20083

Open
Dumluregn wants to merge 6 commits intomasterfrom
cc/ai-multi-support
Open

Added the ViewDocument#getRoots() method#20083
Dumluregn wants to merge 6 commits intomasterfrom
cc/ai-multi-support

Conversation

@Dumluregn
Copy link
Copy Markdown
Contributor

@Dumluregn Dumluregn commented Apr 17, 2026

🚀 Summary

A brief summary of what this PR changes.


📌 Related issues

  • Closes #000

💡 Additional information

Optional: Notes on decisions, edge cases, or anything helpful for reviewers.


🧾 Checklists

Use the following checklists to ensure important areas were not overlooked.
This does not apply to feature-branch merges.
If an item is not relevant to this type of change, simply leave it unchecked.

Author checklist

  • Is the changelog entry intentionally omitted?
  • Is the change backward-compatible?
  • Have you considered the impact on different editor setups and core interactions? (e.g., classic/inline/multi-root/many editors, typing, selection, paste, tables, lists, images, collaboration, pagination)
  • Has the change been manually verified in the relevant setups?
  • Does this change affect any of the above?
  • Is performance impacted?
  • Is accessibility affected?
  • Have tests been added that fail without this change (against regression)?
  • Have the API documentation, guides, feature digest, and related feature sections been updated where needed?
  • Have metadata files (ckeditor5-metadata.json) been updated if needed?
  • Are there any changes the team should be informed about (e.g. architectural, difficult to revert in future versions or having impact on other features)?
  • Were these changes documented (in Logbook)?

Reviewer checklist

  • PR description explains the changes and the chosen approach (especially when performance, API, or UX is affected).
  • The changelog entry is clear, user‑ or integrator-facing, and it describes any breaking changes.
  • All new external dependencies have been approved and mentioned in LICENSE.md (if any).
  • All human-readable, translateable strings in this PR been introduced using t() (if any).
  • I manually verified the change (e.g., in manual tests or documentation).
  • The target branch is correct.

Comment thread packages/ckeditor5-engine/src/view/document.ts
@oleq oleq changed the title Add missing API Added the ViewDocument#getRoots() method Apr 22, 2026
@oleq oleq marked this pull request as ready for review April 22, 2026 14:24
* Detached roots **are not** returned by this method by default. This is to make sure that all features or algorithms that operate
* on the document data know which roots are still a part of the document and should be processed.
*
* @param includeDetached Specified whether detached roots should be returned as well.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parameter does not exist in the method signature.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d551de6. Configure here.

Comment thread packages/ckeditor5-engine/src/view/document.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants