Skip to content

Fix inconsistent marker boundary order v2#20084

Merged
niegowski merged 4 commits intomasterfrom
ck/19975-marker-boundary-order-v2
Apr 30, 2026
Merged

Fix inconsistent marker boundary order v2#20084
niegowski merged 4 commits intomasterfrom
ck/19975-marker-boundary-order-v2

Conversation

@niegowski
Copy link
Copy Markdown
Contributor

@niegowski niegowski commented Apr 17, 2026

🚀 Summary

Fixes incorrect order of adjacent marker boundary elements in editing downcast.


📌 Related issues


💡 Additional information

Code from this PR was previously merged and reverted because of invalid sorts of markers. In this PR, the sort was fixed.


🧾 Checklists

Use the following checklists to ensure important areas were not overlooked.
This does not apply to feature-branch merges.
If an item is not relevant to this type of change, simply leave it unchecked.

Author checklist

  • Is the changelog entry intentionally omitted?
  • Is the change backward-compatible?
  • Have you considered the impact on different editor setups and core interactions? (e.g., classic/inline/multi-root/many editors, typing, selection, paste, tables, lists, images, collaboration, pagination)
  • Has the change been manually verified in the relevant setups?
  • Does this change affect any of the above?
  • Is performance impacted?
  • Is accessibility affected?
  • Have tests been added that fail without this change (against regression)?
  • Have the API documentation, guides, feature digest, and related feature sections been updated where needed?
  • Have metadata files (ckeditor5-metadata.json) been updated if needed?
  • Are there any changes the team should be informed about (e.g. architectural, difficult to revert in future versions or having impact on other features)?
  • Were these changes documented (in Logbook)?

Reviewer checklist

  • PR description explains the changes and the chosen approach (especially when performance, API, or UX is affected).
  • The changelog entry is clear, user‑ or integrator-facing, and it describes any breaking changes.
  • All new external dependencies have been approved and mentioned in LICENSE.md (if any).
  • All human-readable, translateable strings in this PR been introduced using t() (if any).
  • I manually verified the change (e.g., in manual tests or documentation).
  • The target branch is correct.

@niegowski niegowski marked this pull request as ready for review April 17, 2026 15:07
@pomek
Copy link
Copy Markdown
Member

pomek commented Apr 20, 2026

@niegowski, could you confirm that tests from Commercial are green, too? At least, AI and TC.

@niegowski
Copy link
Copy Markdown
Contributor Author

@niegowski, could you confirm that tests from Commercial are green, too? At least, AI and TC.

It reqired a slight change in TC test: https://github.com/ckeditor/ckeditor5-commercial/pull/9773

@pomek
Copy link
Copy Markdown
Member

pomek commented Apr 20, 2026

Thanks @niegowski. It's good to see that now we are prepared :D

Copy link
Copy Markdown
Contributor

@f1ames f1ames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

Just some minor docs-related suggestions.

Comment thread packages/ckeditor5-engine/src/conversion/comparemarkers.ts Outdated
Comment thread packages/ckeditor5-engine/src/conversion/downcastdispatcher.ts Outdated
@niegowski niegowski requested a review from f1ames April 29, 2026 15:28
Copy link
Copy Markdown
Contributor

@f1ames f1ames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@niegowski niegowski merged commit 0462e25 into master Apr 30, 2026
12 checks passed
@niegowski niegowski deleted the ck/19975-marker-boundary-order-v2 branch April 30, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect order of adjacent marker boundary elements in editing downcast

3 participants