Skip to content

[WiP] Make sure all data parsing or schema related checks use proper/actual root#20101

Open
niegowski wants to merge 6 commits intomasterfrom
ck/20026
Open

[WiP] Make sure all data parsing or schema related checks use proper/actual root#20101
niegowski wants to merge 6 commits intomasterfrom
ck/20026

Conversation

@niegowski
Copy link
Copy Markdown
Contributor

@niegowski niegowski commented Apr 23, 2026

🚀 Summary

A brief summary of what this PR changes.


📌 Related issues


💡 Additional information

Optional: Notes on decisions, edge cases, or anything helpful for reviewers.


🧾 Checklists

Use the following checklists to ensure important areas were not overlooked.
This does not apply to feature-branch merges.
If an item is not relevant to this type of change, simply leave it unchecked.

Author checklist

  • Is the changelog entry intentionally omitted?
  • Is the change backward-compatible?
  • Have you considered the impact on different editor setups and core interactions? (e.g., classic/inline/multi-root/many editors, typing, selection, paste, tables, lists, images, collaboration, pagination)
  • Has the change been manually verified in the relevant setups?
  • Does this change affect any of the above?
  • Is performance impacted?
  • Is accessibility affected?
  • Have tests been added that fail without this change (against regression)?
  • Have the API documentation, guides, feature digest, and related feature sections been updated where needed?
  • Have metadata files (ckeditor5-metadata.json) been updated if needed?
  • Are there any changes the team should be informed about (e.g. architectural, difficult to revert in future versions or having impact on other features)?
  • Were these changes documented (in Logbook)?

Reviewer checklist

  • PR description explains the changes and the chosen approach (especially when performance, API, or UX is affected).
  • The changelog entry is clear, user‑ or integrator-facing, and it describes any breaking changes.
  • All new external dependencies have been approved and mentioned in LICENSE.md (if any).
  • All human-readable, translateable strings in this PR been introduced using t() (if any).
  • I manually verified the change (e.g., in manual tests or documentation).
  • The target branch is correct.

@niegowski niegowski changed the title Make sure all data parsing or schema related checks use proper/actual root [WiP] Make sure all data parsing or schema related checks use proper/actual root Apr 23, 2026
@niegowski niegowski marked this pull request as ready for review April 23, 2026 16:35
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 65d82d2. Configure here.

if ( modelRoot.childCount < 2 ) {
// Only insert the paragraph body placeholder when the root actually accepts `paragraph`.
// Custom/inline roots that do not accept `$block` are intentionally skipped.
if ( modelRoot.childCount < 2 && schema.checkChild( modelRoot, 'paragraph' ) ) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_fixBodyElement missing title support guard unlike other methods

Medium Severity

_fixBodyElement guards on schema.checkChild(modelRoot, 'paragraph') but unlike every other post-fixer and method in this file (_fixTitleElement, _getTitleElement, getBody, the view post-fixer, and the Shift+Tab handler), it does not also guard on schema.checkChild(modelRoot, 'title'). A custom root that accepts paragraph but not title would get an unwanted empty body-placeholder paragraph inserted at position 1 — even though no title structure exists or is expected on that root.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 65d82d2. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make sure all data parsing or schema related checks use proper/actual root

1 participant