Skip to content

fix: __cplusplus check for <version> header#473

Merged
ckormanyos merged 1 commit intockormanyos:masterfrom
tearfur:patch-1
Jan 13, 2026
Merged

fix: __cplusplus check for <version> header#473
ckormanyos merged 1 commit intockormanyos:masterfrom
tearfur:patch-1

Conversation

@tearfur
Copy link
Contributor

@tearfur tearfur commented Jan 9, 2026

<version> is a standard C++20 feature, so I figured the correct __cplusplus value should be 202002L.

In practice, this PR fixes a compiler warning when compiling on C++20 on g++15:

In file included from /transmission/third-party/wide-integer/math/wide_integer/uintwide_t.h:17,
                 from /transmission/libtransmission/peer-mse.cc:12:
/usr/include/c++/15/ciso646:49:6: warning: #warning "<ciso646> is not a standard header since C++20, use <version> to detect implementation-specific macros" [-Wcpp]
   49 | #    warning "<ciso646> is not a standard header since C++20, use <version> to detect implementation-specific macros"
      |      ^~~~~~~

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (aed8a39) to head (59f48b0).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #473   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files          41       41           
  Lines        3772     3769    -3     
  Branches      320      320           
=======================================
- Hits         3772     3769    -3     
Files with missing lines Coverage Δ
math/wide_integer/uintwide_t.h 100.0% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aed8a39...59f48b0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ckormanyos
Copy link
Owner

Oh I think I forgot this. Let me get it done.

@ckormanyos ckormanyos merged commit a0c823e into ckormanyos:master Jan 13, 2026
65 of 66 checks passed
@tearfur tearfur deleted the patch-1 branch January 13, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments