Upgrade to gleam_stdlib 0.60.0 and use gleam/dynamic/decode#1
Open
bchase wants to merge 2 commits intockreiling:mainfrom
Open
Upgrade to gleam_stdlib 0.60.0 and use gleam/dynamic/decode#1bchase wants to merge 2 commits intockreiling:mainfrom
gleam_stdlib 0.60.0 and use gleam/dynamic/decode#1bchase wants to merge 2 commits intockreiling:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made an attempt at upgrading to
gleam/dynamic/decode, but I'm not entirely sure I got logic correct...For instance, I switched the order of decoders (to IPv6 before IPv4) to get the tests to pass, but I'm not sure if there was a reason the order was the opposite prior.
Let me know if you'd like anything moved around. Cheers!