Skip to content

Remove flash memory store; back tests with session store#37

Merged
diasbruno merged 1 commit into
developmentfrom
copilot/create-flash-message-requirements
May 30, 2026
Merged

Remove flash memory store; back tests with session store#37
diasbruno merged 1 commit into
developmentfrom
copilot/create-flash-message-requirements

Conversation

Copilot AI commented May 29, 2026

Copy link
Copy Markdown
Contributor

Flash message stores should be implemented against the session backend the user is already using — a generic in-memory store is the wrong abstraction here.

Changes

  • Deleted flash/memory-store.lisp and io.github.cl-sdk.wst.flash.memory-store.asd
  • Rewrote t/flash-tests.lisp to drive core engine tests (type validation, length limits, queue overflow, session isolation) through a SQLite-backed session-flash-store, matching the pattern already established in flash-session-tests.lisp
  • Updated io.github.cl-sdk.wst.flash.test.asd dependencies: replaced flash.memory-store with sqlite, flash.session-store, session, and session.sqlite

Tests that validate engine-level constraints (unknown type, oversized text) fire before any store interaction, so they work without a pre-existing session. Tests that enqueue messages create a real SQLite session first via a make-test-session helper.

(with-flash-engine (session-store engine :max-messages-per-session 1)
  (let ((session-id (make-test-session session-store "s1")))
    (add-flash-message engine session-id :info "one")
    (signals error
      (add-flash-message engine session-id :info "two"))))

@diasbruno diasbruno force-pushed the copilot/create-flash-message-requirements branch from a963d5a to e8e4510 Compare May 30, 2026 02:49
@diasbruno diasbruno marked this pull request as ready for review May 30, 2026 02:49
@diasbruno diasbruno merged commit 5f7a65d into development May 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants