Remove flash memory store; back tests with session store#37
Merged
Merged
Conversation
Copilot created this pull request from a session on behalf of
diasbruno
May 29, 2026 20:40
View session
a963d5a to
e8e4510
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flash message stores should be implemented against the session backend the user is already using — a generic in-memory store is the wrong abstraction here.
Changes
flash/memory-store.lispandio.github.cl-sdk.wst.flash.memory-store.asdt/flash-tests.lispto drive core engine tests (type validation, length limits, queue overflow, session isolation) through a SQLite-backedsession-flash-store, matching the pattern already established inflash-session-tests.lispio.github.cl-sdk.wst.flash.test.asddependencies: replacedflash.memory-storewithsqlite,flash.session-store,session, andsession.sqliteTests that validate engine-level constraints (unknown type, oversized text) fire before any store interaction, so they work without a pre-existing session. Tests that enqueue messages create a real SQLite session first via a
make-test-sessionhelper.