test(ipc): add push_message handler tests and daemon_sock_path assertion (lr-f0ca)#204
Closed
akuehner wants to merge 1 commit into
Closed
test(ipc): add push_message handler tests and daemon_sock_path assertion (lr-f0ca)#204akuehner wants to merge 1 commit into
akuehner wants to merge 1 commit into
Conversation
…ion (lr-f0ca) Add ipc-push-message.test.js covering the five handler contract cases (missing sessionId, missing text, session not found, session found, handler throws) using createIPCServer + sendIPCCommand over real Unix sockets in os.tmpdir(). Update relay-agent-claims.test.js fake server to capture request bodies and assert that the register body includes a non-empty daemon_sock_path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
relay-agent-claims.test.jsfake server to capture the register request body and assertdaemon_sock_pathis present and non-empty (Peaches nit 2: a refactor could silently drop the field with tests still green)test/ipc-push-message.test.jswith 7 tests covering the fullpush_messagehandler contract: missingsessionId, missingtext, session not found, session found (verifiespushMessagecalled with correct args), and handler-throws path (Peaches nit 1: no automated test for the IPC case)Test plan
npm testpasses (177/177 — up from 168)push_messageerror paths and the happy pathdaemon_sock_pathassertion catches any future accidental removal of the fieldCloses Peaches nits on lr-f0ca (push_message IPC + daemon_sock_path relay claim).
🤖 Generated with Claude Code