Fix for accessibility permissions#9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds new documentation and improves the handling and testing of Accessibility permissions required for launching different terminal applications from the app. The most significant changes include the addition of a developer guide, refinement of permission logic for terminal automation, and comprehensive unit tests to ensure correct behavior.
Documentation:
CLAUDE.md, a detailed developer guide covering build/test commands, architecture, service responsibilities, UI patterns, and release process.Terminal Accessibility Permissions Logic:
supportsAppleScriptproperty with a more preciserequiresSystemEventsAccessproperty on theTerminalService.Terminalenum, distinguishing between terminals that require Accessibility permissions (Warp, Ghostty) and those that do not (Terminal.app, iTerm2).requiresAccessibilityPermissions(_:)method inTerminalServiceto use the new property, improving clarity and correctness.Testing:
TerminalServiceTests.swiftwith comprehensive tests for the new permission logic, verifying which terminals require Accessibility permissions and ensuring the correct AppleScript templates are used for each terminal type.