Skip to content

Fix for accessibility permissions#9

Merged
clarkemn merged 2 commits into
mainfrom
clarkemn/ghossty-fix
Mar 8, 2026
Merged

Fix for accessibility permissions#9
clarkemn merged 2 commits into
mainfrom
clarkemn/ghossty-fix

Conversation

@clarkemn

@clarkemn clarkemn commented Mar 8, 2026

Copy link
Copy Markdown
Owner

This pull request adds new documentation and improves the handling and testing of Accessibility permissions required for launching different terminal applications from the app. The most significant changes include the addition of a developer guide, refinement of permission logic for terminal automation, and comprehensive unit tests to ensure correct behavior.

Documentation:

  • Added CLAUDE.md, a detailed developer guide covering build/test commands, architecture, service responsibilities, UI patterns, and release process.

Terminal Accessibility Permissions Logic:

  • Replaced the generic supportsAppleScript property with a more precise requiresSystemEventsAccess property on the TerminalService.Terminal enum, distinguishing between terminals that require Accessibility permissions (Warp, Ghostty) and those that do not (Terminal.app, iTerm2).
  • Updated the requiresAccessibilityPermissions(_:) method in TerminalService to use the new property, improving clarity and correctness.

Testing:

  • Added TerminalServiceTests.swift with comprehensive tests for the new permission logic, verifying which terminals require Accessibility permissions and ensuring the correct AppleScript templates are used for each terminal type.
  • Registered the new test file in the package manifest to ensure it runs as part of the test suite.

@clarkemn clarkemn merged commit 594ba3c into main Mar 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant