Set the input-type of the hoursminutes-input to number#24
Open
Anubiso wants to merge 1 commit intoclasslinkinc:masterfrom
Open
Set the input-type of the hoursminutes-input to number#24Anubiso wants to merge 1 commit intoclasslinkinc:masterfrom
Anubiso wants to merge 1 commit intoclasslinkinc:masterfrom
Conversation
In the mobile context the opened virrtual keyboard is defined by the input type. For this reason and because hours and minutes can only be numbers this should be a number-input.
Author
|
"09" for example is also valid in a number-type input |
Contributor
|
Currently it acts fine as a text type input field. It validates fine and you can select hour and minute from the md-clock directive. Why do you want a number type input field? |
Author
|
When you are using text type input field on mobile devices (android or apple or windows) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


In the mobile context the opened virrtual keyboard is defined by the input type.
For this reason and because hours and minutes can only be numbers this should be a number-input.