Skip to content

fix(dom): reset auto scroller state on cleanup#2109

Open
wanxiankai wants to merge 1 commit into
clauderic:mainfrom
wanxiankai:fix/stop-autoscroll-after-drag
Open

fix(dom): reset auto scroller state on cleanup#2109
wanxiankai wants to merge 1 commit into
clauderic:mainfrom
wanxiankai:fix/stop-autoscroll-after-drag

Conversation

@wanxiankai

Copy link
Copy Markdown

Summary

  • reset the shared Scroller.autoScrolling flag when AutoScroller cleans up its interval
  • add a regression test for AutoScroller cleanup
  • add a patch changeset for @dnd-kit/dom

Closes #2072.

Testing

  • ./node_modules/.bin/prettier --check packages/dom/src/core/plugins/scrolling/AutoScroller.ts packages/dom/tests/auto-scroller.test.ts .changeset/quiet-scrolls-stop.md
  • ./node_modules/.bin/tsc packages/dom/tests/auto-scroller.test.ts --noEmit --target es6 --module NodeNext --moduleResolution NodeNext --lib dom,dom.iterable,ES2015 --allowImportingTsExtensions --isolatedModules --strict --skipLibCheck --types bun-types

Note: I could not run bun test locally because bun is not installed in this environment.

@changeset-bot

changeset-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9055a69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@dnd-kit/dom Patch
@dnd-kit/abstract Patch
@dnd-kit/collision Patch
@dnd-kit/geometry Patch
@dnd-kit/helpers Patch
@dnd-kit/react Patch
@dnd-kit/state Patch
@dnd-kit/vue Patch
@dnd-kit/solid Patch
@dnd-kit/svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dragging a item with auto-scroll, can in certain situation cause stuck scroll

1 participant