Skip to content

Fix off-by-one in moving_wall_bc ghost fill (stegoton_1d) #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ketch merged 2 commits into from
Jun 25, 2026
Merged

Fix off-by-one in moving_wall_bc ghost fill (stegoton_1d) #757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66de600
Fix off-by-one in moving_wall_bc ghost fill (stegoton_1d)
bypire Jun 23, 2026
6745c28
Regenerate stegoton expected_sols.npy after the ghost-fill fix
bypire Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified examples/stegoton_1d/expected_sols.npy
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion examples/stegoton_1d/stegoton.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def moving_wall_bc(state,dim,t,qbc,auxbc,num_ghost):
t0 = (t-t1)/tw1
if abs(t0)<=1.: vwall = -a1*(1.+np.cos(t0*np.pi))
else: vwall=0.
for ibc in range(num_ghost-1):
for ibc in range(num_ghost):
qbc[1,num_ghost-ibc-1] = 2*vwall*state.aux[1,ibc] - qbc[1,num_ghost+ibc]


Expand Down
Loading