codelicious v2: spec completion, security closure, coverage hardening#10
Merged
Conversation
…mpletion
Implements specs 20-27 bringing the codebase to production-ready MVP status:
- Spec 20: Remove --dangerously-skip-permissions unconditionally, SSRF validation,
block git-add-dot, prompt injection sanitization
- Spec 22: PR deduplication with deterministic spec-to-branch mapping
(codelicious/spec-{N}), one-spec-equals-one-PR invariant
- Spec 24: Dead code removal (budget_guard, build_logger, executor, progress,
structured_logger — ~900 lines removed)
- Spec 25: Repo hygiene — remove .codelicious/ build artifacts from git,
rename versioned test files, clean __init__.py public API
- Spec 26: Fix spec discovery bugs — remove _git_tracked_files filter,
accept untracked specs and all .md filenames
- Spec 27: v2 orchestration rewrite — chunk-based execution with
one-commit-per-chunk, auth preflight (gh/glab), GPG signing fallback
Quality gates all green:
- 1,871 tests passing (0 failures)
- 93% line coverage (enforced via --cov-fail-under=90)
- 0 ruff lint violations
- 0 bandit security findings
- README aligned with actual CLI flags and architecture
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--dangerously-skip-permissionsremoved unconditionally (Spec 20) — flag blocked viaFORBIDDEN_CLI_FLAGS, CLI flag and env var strippedcodelicious/spec-{N}branch naming,ensure_draft_pr_existsqueries all open PRs, agent prompt stripped of PR creation instructionsbudget_guard.py,build_logger.py,executor.py,progress.py,structured_logger.pydeleted (~900 lines).codelicious/build artifacts untracked, versioned test files renamed, legacy fixtures removed_git_tracked_files()removed, accepts untracked specs and all.mdfilenamesgh/glab), GPG signing fallback--cov-fail-under=90# nosecannotations)--allow-dangerous, added missing flags and modulesQuality gates
Test plan
python3.12 -m pytest— 1,871 tests passruff check src/ tests/— 0 violationsbandit -r src/ -c pyproject.toml— 0 findings🤖 Generated with Claude Code