codelicious: spec-v5 build — hardening & review fixes#9
Merged
Conversation
Automated build of spec-v5 (bulletproof MVP hardening). Changes include: Source fixes (~25 files): - Performance: O(n^2) list ops, N+1 HTTP batching, in-process compile(), regex pre-filter, schema/scan caching - Reliability: Subprocess timeouts (git, gh), worktree commit handling, concurrency locks, file handle safety, retry-with-backoff - Security: Gated dangerous permissions, sensitive file unstaging, expanded command denylist, TOCTOU symlink cleanup, SSRF validation, rate limiting Test fixes (~25 test files): - Fixed 15 always-passing tests (trivial assertions, bare excepts, wrong exception types) - Added ~100 new test cases for security guards, error paths, validators - Fixed mock targets, non-deterministic assertions, conditional guards Final: 969 tests passing, lint clean, format clean. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove unused `subprocess` imports in test_claude_engine.py (lines 766, 813) - Remove unused `patch` import in test_planner.py - Remove unused `real_project` variable in test_sandbox.py Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace Path.walk() (added in 3.12) with os.walk() in claude_engine._walk_for_specs to support Python 3.10 and 3.11. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… git lifecycle, resolved 26 security vulnerabilities (SSRF, path traversal, and prompt injection), and expanded the test suite to 1884 passing tests with 90%+ coverage
… pip-audit errors in security job
…d requirements file to prevent false positives during strict dependency checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
test_budget_guard,test_config,test_engines,test_orchestrator,test_prompts,test_tool_registryTest plan
🤖 Generated with Claude Code