fix(observability): use platform-correct log directories and atomic writes#3
Merged
fix(observability): use platform-correct log directories and atomic writes#3
Conversation
…rites Logs were landing in XDG-style paths on macOS instead of ~/Library/Logs/. Replace the generic ProjectDirs fallback with platform_log_dir() that resolves correctly per OS: macOS ~/Library/Logs/, Linux $XDG_STATE_HOME, Windows LocalAppData. Also buffer each JSON log line into a single write() syscall so concurrent O_APPEND writers can't interleave partial lines. Accept service name as a caller parameter in from_env_with_overrides instead of hard-coding CARGO_PKG_NAME at compile time. Isolate integration tests from production log paths via env var override. Release-Note: Fix log files writing to wrong directory on macOS Release-Impact: medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logs were landing in XDG-style paths on macOS instead of
~/Library/Logs/. Replace the generic ProjectDirs fallback with
platform_log_dir() that resolves correctly per OS:
macOS ~/Library/Logs/, Linux $XDG_STATE_HOME, Windows LocalAppData.
Also buffer each JSON log line into a single write() syscall so
concurrent O_APPEND writers can't interleave partial lines.
Accept service name as a caller parameter in from_env_with_overrides
instead of hard-coding CARGO_PKG_NAME at compile time. Isolate
integration tests from production log paths via env var override.
Release-Note: Fix log files writing to wrong directory on macOS
Release-Impact: medium